codecentric / net_automatic_interface

.Net Source Generator for Automatic Interfaces
MIT License
62 stars 14 forks source link

Enable internal classes #43

Open anotherthomas opened 8 months ago

anotherthomas commented 8 months ago

To facilitate API design for assemblies, [GenerateAutomaticInterface] should take internal visibility into account. The interface can be useful for dependency injection without necessarily being part of the public API of an assembly.

ChristianSauer commented 8 months ago

I like it, can you do a few things:

  1. Add tests for all relevant cases (no modifies, public, private, internal, protected?) Ideally add another partial class for that, the current test class is a "little" long.
  2. Bump the version to next major - this is a breaking change
  3. Mention it in the readme

Thanks!

anotherthomas commented 8 months ago

Sure thing

anotherthomas commented 7 months ago

So, working on the broader topic, what would we want to have? Going over https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/access-modifiers:

Wrt. nested members:

What are your thoughts on that?

ChristianSauer commented 7 months ago

Sorry, I was occupied :( After reading - i would say both question marks are out of scope for now. Let's start with the simple stuff...

anotherthomas commented 7 months ago

Tests split, version bumped :)

anotherthomas commented 3 months ago

Sorry, had several things on my plate those last few months. Still interested?

ChristianSauer commented 3 months ago

Yes! You need probably to rebase