codecentric / springboot-maven3-centos

S2I builder image for building and running maven based Spring Boot applications
https://hub.docker.com/r/codecentric/springboot-maven3-centos/
Apache License 2.0
30 stars 67 forks source link

Add buildargs #7

Closed luiscoms closed 7 years ago

luiscoms commented 7 years ago

Thanks for @miklosbarabas for changes

britter commented 7 years ago

Wow, very nice! I'll need some time to test this change with my demo app. Thank you!

luiscoms commented 7 years ago

I just added target dir to default value

britter commented 7 years ago

@luiscoms when I run:

docker build -t codecentric/springboot-maven3-centos .
s2i build https://github.com/codecentric/springboot-sample-app codecentric/springboot-maven3-centos springboot-sample-app

I get:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:46 min
[INFO] Finished at: 2016-09-20T06:58:00+00:00
[INFO] Final Memory: 31M/75M
[INFO] ------------------------------------------------------------------------
ERROR: chgrp: cannot access './.pki/nssdb': Permission denied
ERROR: chmod: cannot access './.pki/nssdb': Permission denied
ERROR: find: './.pki/nssdb': Permission denied

ERROR: An error occurred: non-zero (13) exit code from codecentric/springboot-maven3-centos

Does this work for you?

luiscoms commented 7 years ago

I Just run make test, that command build the image and run test-app

luiscoms commented 7 years ago

I Just run make test, and the tests are passing. I ran your command and image built successfully

britter commented 7 years ago

Thank you!