Ensure scenario termination

codeceptjs / CodeceptJS

Supercharged End 2 End Testing Framework for NodeJS

http://codecept.io

MIT License

4.11k stars 722 forks source link

Ensure scenario termination #4378

Closed Horsty80 closed 3 months ago

Horsty80 commented 3 months ago

Motivation/Description of the PR

The CLI was staling on some cases (promise and throw error). We manage to reproduce this behavior. Added some text and fixe this issue inside scenario.js code
Resolves #4358 , #4197 , #3640, #4378

Also, we have updated done() to prevent it from being called more than once inside Scenario. Possibly the root of this kind of error. Error: done() called multiple times in

Applicable helpers:

[x] Playwright

Type of change

[x] :bug: Bug fix
[x] 🧹 Chore
[x] :nail_care: Polish code

Checklist:

[x] Tests have been added
[x] Local tests are passed (Run npm test)

Horsty80 commented 3 months ago

Hey @kobenguyent I've find and fix that cause the issue #4197 that you talk about here https://github.com/codeceptjs/CodeceptJS/pull/4377#issuecomment-2149360983

I have added the test case here and it's ok

https://github.com/codeceptjs/CodeceptJS/pull/4378/files#diff-1d3c534eda54e8e8ac941eb8fcce76dad6eb240a5def22158aea06cf097a5135R20

kobenguyent commented 3 months ago

as this also addresses the stale process, so I think we would combine them into a branch. Then provide a beta version to test it out.

kobenguyent commented 3 months ago

hi @Horsty80 would you mind checking the failed tests? I changed the base branch there are some conflicts, I tried to resolve them but some failed tests.

Horsty80 commented 3 months ago

hi @Horsty80 would you mind checking the failed tests? I changed the base branch there are some conflicts, I tried to resolve them but some failed tests.

Yes of course ! I know that will be conflict with my other PR ^^ I will fix that and push changes today