codeceptjs / helper

Base class for CodeceptJS helpers
MIT License
1 stars 4 forks source link

Adding parameter to _before hook #4

Closed jayudey-wf closed 2 years ago

jayudey-wf commented 2 years ago

I was starting to implement typescript in a repo that utilizes codeceptJs and noticed that I couldn't compile because of a type mismatch.

This update makes the type definition match the current usage in codeceptJs I believe, https://github.com/codeceptjs/CodeceptJS/blob/master/lib/listener/helpers.js#L45-L48

Thanks!

jayudey-wf commented 2 years ago

@DavertMik for your review

sorry if you already got a notification 😢 , I don't know how the notifications are set up

DavertMik commented 2 years ago

Thanks!