search

codechavez / angular-inline-editor

angular-inline-editor is a small Angular library that allows the experience to use editable elements (click-to-edit) without the pain and/or hassle.
https://www.npmjs.com/package/angular-inline-editors
MIT License
9 stars 11 forks source link

AOT compatibility #5

Closed klords closed 6 years ago

klords commented 6 years ago

Adding AOT compatibility. For users that got errors related to function calls occurring in decorators, this was due to the inline editor module decorator being compiled as a function, preventing the module from being usable in AOT. Resolved by using the Angular compiler to do the library compilation instead of tsc. Additionally, there were other issues that needed to be resolved for AOT compatibility, specifically a lot of variables needed to be made public to be accessible to the template. FWIW, the library can be compiled and used just using the compile script, since html and css get packed in.

Lastly, there was a minor fix for the number editor. (It was broken in the demo due to using string comparison instead of numeric comparison.)

fixes #1 fixes #3

codechavez commented 6 years ago

Thank you for taking the time. We are reviewing your pull request.