Closed angelina-momin closed 6 months ago
@nuest I cannot add anyone as reviewer so I am tagging you here to ask for a review.
@nuest The checks are failing because r-lib/actions no longer has a master branch: link. Their default branch is now called "v2-branch". Should I update the workflow file and replace "master" with "v2-branch"?
Hi @angelina-momin ! Yes, please do update the workflow file as you see fit.
Changes look good to me, only one more thing: Can you please bump the development version to 0.1.0.9006
in the DESCRIPTION
file, see https://github.com/codecheckers/codecheck/blob/master/DESCRIPTION#L3C10-L3C20
Also, your personal details are missing in the DESCRIPTION
file.
Once you changes become more significant, I'm very open to make a decent version bump and proper release - let's try to not forget that.
Made the following changes:
register.R
utils_preprocess_register.R
utils_render_register.R
utils_register_check.R
DESCRIPTION
fileDESCRIPTION
fileR-CMD-check.yaml
to use r-lib's v2-branch instead of master branch. Otherwise the workflow runs fail. The "master" branch was replaced with "v2-branch"Already tested it out by running the function and checking the results and it looks good.