codecheckers / codecheck

R package assistant for conducting a CODECHECK
MIT License
10 stars 3 forks source link

Refactor render register file #38

Closed angelina-momin closed 6 months ago

angelina-momin commented 7 months ago

Made the following changes:

Already tested it out by running the function and checking the results and it looks good.

angelina-momin commented 7 months ago

@nuest I cannot add anyone as reviewer so I am tagging you here to ask for a review.

angelina-momin commented 7 months ago

@nuest The checks are failing because r-lib/actions no longer has a master branch: link. Their default branch is now called "v2-branch". Should I update the workflow file and replace "master" with "v2-branch"?

nuest commented 6 months ago

Hi @angelina-momin ! Yes, please do update the workflow file as you see fit.

Changes look good to me, only one more thing: Can you please bump the development version to 0.1.0.9006 in the DESCRIPTION file, see https://github.com/codecheckers/codecheck/blob/master/DESCRIPTION#L3C10-L3C20 Also, your personal details are missing in the DESCRIPTION file.

Once you changes become more significant, I'm very open to make a decent version bump and proper release - let's try to not forget that.