Closed angelina-momin closed 2 months ago
@nuest I am redoing the code and thought of dropping the "type" and "venue" column for page of registers by venue since those columns are redundant. Tidyr's nest()
function also drops the column by which grouping is done so in case of filter by venue it drops the venue column in the resulting nested tables.
Is that okay with you? The json files will only contain the information showed on the page
Refer to the top screenshot for the new look and the bottom screenshot of the old look.
Yes, dropping the column is fine - even for the JSON the information is encoded in the URL.
Can you easily change the order to Certificate, Report, Repository, Issue, Check date
? If extremely easy maybe do it, it more than a minute of work I will create an issue.
It would also be good to get the title in there, I think we have an issue for that..
@nuest The code is ready for review again. Redid a lot of code on filtering the tables following your suggestion to use tidyr. Please refer to the description of the PR for what I changed.
Can you create a separate issue for the JSON column order please? Prefer a separate issue because this PR already combines two PRs
Wow, what a rewrite. Not easy to digest for me, but I find the new code quite readable. What do you think? Are you happier with the new approach?
Yes I am happy with the new approach. Simpler, easier to read and should be more efficient :)
Only had a few minor remarks. I'm fine if you go ahead and merge yourself after the final couple of changes, as I might be a bit busy the next days.
Good job!
Thanks! Just resolved the comments and i'll proceed with merging
Solves issues:
Related register PR #98
In the
register.csv
the column "type" was split into into "type" and "venue" where Venue = what is in brackets now Type = outside of bracketsChanges made:
0.7.0
utils_filter_register_table.R
withutils_render_register_general.R
. The new filtering functionalities utilizes tidyr, dplyr and magrittr functionalities to filter the data which is more efficient than the previous method I used.MD_COLUMNS_WIDTHS
,MD_TITLES
,FILTER_COLUMN_NAMES
,NON_REG_TITLE_FNS
,JSON_COLUMNS
and moreman