search

codecheckers / register

Register of CODECHECK certificates
https://codecheck.org.uk/register/
Other
6 stars 2 forks source link

Add list of all codecheckers #71

Closed nuest closed 3 months ago

nuest commented 4 months ago

Currently you have to know the ORCID of a checker to construct the URL from knowing the ORCID.

There should be a list of all checkers, sorted by ORCID, at https://codecheck.org.uk/register/codecheckers/

The formats should be HTML, so https://codecheck.org.uk/register/codecheckers/index.html, and JSON: https://codecheck.org.uk/register/codecheckers/index.json. Both listing should include the clear name and a link resp. URL of the codechecker's personal register in the respective format.

(Open new issues for possible extensions, such as showing the number of checks for each individual, ...)

angelina-momin commented 3 months ago

@nuest this is what I have at the moment. Can you lmk if you would like any changes? The codechecker name links to the codecheck website with all their codechecks. The orcid ID links to their orcid pages. The "JSON" links to the index.json file

image

nuest commented 3 months ago

Thanks, @angelina-momin - looks good!

Firsr suggestion I have is that you also link the values "No. of checks" column to the codechecker page that lists these checks.

Second idea: Do you have an idea how you could integrate the number of checkers? The headline seems a bit too strong for that. But it would be nice to read that number instead of trying to count through the rows. A "sum row" seems an option but might be confusing without explanation.

Maybe a sentence after the headline, before the table?

"In total, N codecheckers contributed M checks."

If we get that to work easily, we could have similar data points in the other overview pages. I can create an issue for that next week, if the second suggestion is unclear.

angelina-momin commented 3 months ago

Thanks for the feedback Daniel. Responding to each of your suggestions:

1) I added links to number of codechecks- added text "(see all checks)" which link to the page with the codechecker's codechecks (this is in line with the suggestion you put in the venues issue). See screenshot below. Do you still want the codechecker name's to link to their codechecks page?

2) Added that line as well.

Please let me know if you need any further changes. If not, I will open the PR for review

image

angelina-momin commented 3 months ago

Accidentally closed the issue

nuest commented 3 months ago

Looks great! Thanks for the changes!

Just a minor question: how is the list sorted? My guess: they are ordered by the ID (effectively the date) of the first CODECHECK that they did.

angelina-momin commented 3 months ago

Great I sent you a review request for the PR.

Currently, the order of the codecheckers on this page follows the order of the certificates and their respective codecheckers in register.csv. Let me know if that's okay with you.

I was thinking we can create a separate issue for "sort by" feature which would be a nice enhancement.

nuest commented 3 months ago

Yes, please do create that issue!

nuest commented 3 months ago

https://codecheck.org.uk/register/codecheckers/ :tada: