search

codechecks / monorepo

Open source platform for code review automation ✅
https://codechecks.io/
98 stars 19 forks source link

Missing dependency on typescript #70

Open interfect opened 4 years ago

interfect commented 4 years ago

@codechecks/client@0.1.10 has a dependency on node-ts ^8.0.2. But node-ts@8.0.2 has a peer dependency on typescript >=2.0, and node-ts@8.6.0 (which is what gets installed today) has a peer dependency on typescript >=2.7.

Since the CodeChecks client module is the one that depends on the module with the peer dependency, as I understand it the CodeChecks client module is the one that is responsible for depending on it as a non-peer dependency. There should be a dependency on typescript >=2.7 to satisfy node-ts, and this dependency needs to be bumped if/when node-ts releases a new version that matches ^8.0.2 and bumps its peer dependency version.

Without this dependency, I get this at the end of npm ls:

npm ERR! peer dep missing: typescript@>=2.7, required by ts-node@8.6.0
interfect commented 4 years ago

To reproduce:

npm install --save --dev @codechecks/client
npm ls
timocov commented 4 years ago

I don't think that ts-node should be in dependencies, it looks strange for me. ts-node usually is used to run typescript code without transpiling locally. @krzkaczor can you please take a look?