search

codeclimate / codeclimate-coffeelint

Code Climate Engine for CoffeeLint
MIT License
4 stars 8 forks source link

Bumps coffeelint 1.15.7 -> 1.16.0 #28

Closed chrishulton closed 7 years ago

chrishulton commented 7 years ago

This also bumps the coffeescript version to 1.11.1 which together should address this issue: https://github.com/codeclimate/codeclimate-coffeelint/issues/26

To upgrade I ran in the code project:

> npm install
> npm update coffeelint --save

nodejs separated out nodejs-npm into a separate package, which is the reason for the Dockerfile change (npm is not found otherwise).

maxjacobson commented 7 years ago

I tried running the tests locally and hit some errors. I think the CI may be misconfigured. It doesn't seem to build the image before running the tests, so it instead pulls the image from dockerhub.

maxjacobson commented 7 years ago

update: I had node_modules from an earlier build lying around on my filesystem, making my image weird/different. I'm green now locally. CI does still look a little strange to me though...

chrishulton commented 7 years ago

@maxjacobson great find. i grabbed the correct config from https://github.com/codeclimate/codeclimate-phpmd/blob/master/circle.yml

Since we weren't overriding the image name in the env variable, it was just using the non-branch tag for the tests.