codeclimate / codeclimate-duplication

Code Climate engine for code duplication analysis
http://codeclimate.com
MIT License
113 stars 24 forks source link

Hash value ommission from Ruby-3.1 #375

Open Zmokizmoghi opened 2 years ago

Zmokizmoghi commented 2 years ago

Hash value omission was introduced with ruby 3.1 - rubyreferences.github.io/rubychanges/3.1.html#values-in-hash-literals-and-keyword-arguments-can-be-omitted

And apparently it breaks codeclimate-duplication engine: Skipping file examle.rb due to exception (Racc::ParseError): example.rb:5 :: parse error on value ":" (tCOLON)

example.rb content:

# frozen_string_literal: true

class Example
  def perform(id)
    Model.find_by!(id:)
  end
end

Thanks

fonji commented 1 year ago

Also breaks flog, so I allowed myself to copy-paste this issue. Thanks @Zmokizmoghi!

fonji commented 1 year ago

Flog has now the beta channel that fixes this :tada: Can we have the same here? :pray: