Closed krzysiek1507 closed 6 years ago
Note: It is required to make eslint-4
working.
ESLint is running with the /usr/local/node_modules/babel-eslint/lib/index.js parser.
Ignoring the following rules that rely on module resolution:
* import/extensions
* import/no-unresolved
* import/no-extraneous-dependencies
* import/no-named-as-default
* import/no-absolute-path
* import/no-duplicates
* import/no-named-as-default-member
/usr/local/node_modules/jsx-ast-utils/lib/values/expressions/index.js:173
throw new Error(errorMessage(type));
^
Error: The prop value with an expression type of BindExpression could not be resolved.
Please file issue to get this fixed immediately.
at Object.extract [as JSXExpressionContainer] (/usr/local/node_modules/jsx-ast-utils/lib/values/expressions/index.js:173:11)
at getValue (/usr/local/node_modules/jsx-ast-utils/lib/values/index.js:48:27)
at extractValue (/usr/local/node_modules/jsx-ast-utils/lib/getPropValue.js:24:12)
at getPropValue (/usr/local/node_modules/jsx-ast-utils/lib/getPropValue.js:41:10)
at /usr/local/node_modules/eslint-plugin-jsx-a11y/lib/rules/no-static-element-interactions.js:76:95
at Array.some (native)
at JSXOpeningElement (/usr/local/node_modules/eslint-plugin-jsx-a11y/lib/rules/no-static-element-interactions.js:75:52)
at listeners.(anonymous function).forEach.listener (/usr/local/node_modules/eslint/lib/util/safe-emitter.js:47:58)
at Array.forEach (native)
at Object.emit (/usr/local/node_modules/eslint/lib/util/safe-emitter.js:47:38)
Looks good to me. Once new images have been built and deployed, this will be on the eslint-4
channel.
Thanks for the contribution.
Thanks! It works!
oops, breaking change...
Fortunately, only one rule:
[breaking] href-no-hash replaced with anchor-is-valid in the recommended and strict configs. Use the invalidHref aspect (active by default) in anchor-is-valid to continue to apply the behavior provided by href-no-hash.
Ugh, it's irritating that a change like that would come in a ".Z" version bump of "X.Y.Z".
Thanks for pointing this out, @ykzts ; it led me right to an example of what needs changing: https://github.com/tootsuite/mastodon/pull/7696/files#diff-0378d5111ab996d5882f4712e9350604R116
Hi @dblandin Can I ask you to merge it? :)