search

codeclimate / codeclimate-eslint

Code Climate Engine for ESLint
MIT License
95 stars 93 forks source link

add setting blocklist #432

Closed modosc closed 5 years ago

modosc commented 5 years ago

i think this might solve #427 and #426 - since we're already disabling all of the import/* rules there's no reason to keep the import/resolver settings - this is what's causing these other modules to be instantiated.

i added local specs but i don't know how to run integration specs inside of the engine/image so i haven't tested that yet.

modosc commented 5 years ago

ping?

modosc commented 5 years ago

ping?

filipesperandio commented 5 years ago

@modosc I will make room for this on my schedule. Likely I will be able to work on in by Monday. Sorry this is taking so long.

modosc commented 5 years ago

thanks! this works, we can now run eslint5.

filipesperandio commented 5 years ago

Changes are not yet in the platform, but CLI should already have it. I am pushing this through today.

modosc commented 5 years ago

oh - it definitely worked this morning for our builds. thanks!

filipesperandio commented 5 years ago

It might be related to some other changes we did last week, I guess.

modosc commented 5 years ago

hah, i'll try again just to be sure

filipesperandio commented 5 years ago

The changes are now live in the platform :D

modosc commented 5 years ago

oh lol, forgot to change our .codeclimate.yml file. changed it and all works as expected, thanks again!