codeclimate / codeclimate-eslint

Code Climate Engine for ESLint

MIT License

95 stars 93 forks source link

Typescript not supported latest channel #468

Closed henrikrudstrom closed 4 years ago

henrikrudstrom commented 5 years ago

Typescript not supported

Actual Behavior

running CODECLIMATE_DEBUG=1 codeclimate analyze -e eslint produces these messages:

Module not supported: eslint-plugin-@typescript-eslint
Module not supported: @typescript-eslint/parser
Module not supported: @typescript-eslint/eslint-plugin

i see it was added to the eslint-5 branch. is there any reason not to add it to the latest branch as well?

stereodenis commented 4 years ago

Any updates on this?

stereodenis commented 4 years ago

This works for me

plugins: 
  eslint:
    enabled: true
    channel: "eslint-6"

@henrikrudstrom

davehenton commented 4 years ago

@henrikrudstrom @stereodenis

Sorry about the confusion with that.

For clarity, our ESLint-5 and ESLint-6 branches do support the above-mentioned typescript modules.

However, our default channel for ESLint (which runs ESLint 3.19.0) does not.

To move forward, you'll need to specify one of these newer versions of ESLint via your committed .codeclimate.yml, as seen in @stereodenis reply above.

stereodenis commented 4 years ago

@henrikrudstrom closing?

henrikrudstrom commented 4 years ago

thanks. yeah this can be closed.