search

codeclimate / codeclimate-eslint

Code Climate Engine for ESLint
MIT License
95 stars 93 forks source link

Upgrade @typescript-eslint/eslint-plugin and @typescript-eslint/parser to 2.29.0 for eslint 6 #478

Closed Loremaster closed 4 years ago

Loremaster commented 4 years ago

That should fix https://github.com/codeclimate/codeclimate-eslint/issues/477

Loremaster commented 4 years ago

@efueger any updates?

efueger commented 4 years ago

@Loremaster - thanks for checking! it's in the queue, but no update yet. 👌

Loremaster commented 4 years ago

@efueger bump. :) Will it be merged soon? We need those changes to be able to enable some checks in our project which are currently blocked by codeclimate.

efueger commented 4 years ago

Hi @Loremaster - checking with the team. Sorry for the wait!

Loremaster commented 4 years ago

@efueger anything I can do to speedup the review and merge?

efueger commented 4 years ago

thanks for the nudge! that's probably the best thing to do @Loremaster .

peterkrieg commented 4 years ago

hi @efueger - wondering if there are any updates on this PR? It would also be a big help to get this merged. Thank you for any info!

Loremaster commented 4 years ago

@efueger it has been over a month since I opened the PR. When do you plan to merge it?

marcotuna commented 4 years ago

I know that this message adds nothing but... Are there any plans to merge this? I have my analysis failing due to this problem. It's really annoying that I can't use codeclimate because most of my projects rely on eslint with typescript validations

peterkrieg commented 4 years ago

@marcotuna totally understand, I'm in a similar situation. @efueger anything we can do to help get this released?

efueger commented 4 years ago

Hi @peterkrieg - thanks for the bump! Checking with my team now. 👌

krzysiek1507 commented 4 years ago

Any chance to release it? ;)

rdadoune commented 4 years ago

Any word on this? Also waiting for this to be fixed.

efueger commented 4 years ago

Hi all,

Good news!

Thanks again for the nudge on this. I'll close this PR, but if you bump into anything else, let me know. Here to help.

Emily

rdadoune commented 4 years ago

Hey @efueger thanks for the update, can you also update typescript? It's currently at version 3.4.4: https://github.com/codeclimate/codeclimate-eslint/blob/640ade071d24ec5ce685e4f7a7b63bc2bb6b157a/package.json#L89 In version 3.7 they added support for optional chaining and nullish coalescing and we're getting parsing errors related to this. Specifically codeclimate reports "Parsing error: Expression expected." when it encounters use of these new features.

Example:

// Optional Chaining
if (foo?.bar?.baz) {
    // ...
}

// Nullish Coalescing
let x = foo ?? bar()
efueger commented 4 years ago

Hey @rdadoune - can you drop a Code Climate link to one of your files showing the parsing error? help@codeclimate.com Thanks!

rdadoune commented 4 years ago

@efueger sure, does this work https://codeclimate.com/repos/5303f5366956801740003195/app/assets/typescripts/packs/v10/premium/phone_presentation/ducks/selectors/demographicsSelector.ts

efueger commented 4 years ago

updated here: https://github.com/codeclimate/codeclimate-eslint/pull/494/files 👍