codeclimate / codeclimate-eslint

Code Climate Engine for ESLint
MIT License
95 stars 93 forks source link

unexpected issues - update prettier #480

Open efueger opened 4 years ago

efueger commented 4 years ago

A customer wrote in reporting they're encountering a large number of codeclimate errors indicating there's a discrepancy somewhere and it's not linting to the same set of rules.

I think the source might be the the prettier dependency version used by the plugin.


Customer's using eslint-5,

(I tried Contributing instructions, but ran into other dependencies that will need to be upgraded. I prefer a second set of eyes/hands to help with this.)

sinani commented 3 years ago

latest prettier version is v6.10.0

Latest prettier version is 2.3.1. You're linking to eslint-config-prettier project.

You need to install an exact Prettier version. https://prettier.io/docs/en/install.html

Install an exact version of Prettier locally in your project. This makes sure that everyone in the project gets the exact same version of Prettier. Even a patch release of Prettier can result in slightly different formatting, so you wouldn’t want different team members using different versions and formatting each other’s changes back and forth.

And I suspect further complications related to eslint-plugin-prettier and/or eslint-config-prettier as well, but that's something I'm trying to verify.