search

codeclimate / codeclimate-eslint

Code Climate Engine for ESLint
MIT License
95 stars 93 forks source link

Update eslint-plugin-react to v7.21.0 #504

Closed SalimBensiali closed 3 years ago

SalimBensiali commented 3 years ago

This is to be able to use the latest options for the react/jsx-no-literals rule. I am happy to raise this across the other channels too.

Thanks!

SalimBensiali commented 3 years ago

Hi @filipesperandio, any updates on this PR?

SalimBensiali commented 3 years ago

Thanks @fede-moya

fede-moya commented 3 years ago

Thanks @fede-moya

Thank you for your contribution and sorry for the delay ! 👋🏼

SalimBensiali commented 3 years ago

No worries, do you see any value in raising similar PRs on the other Eslint channel branches? This will bite us again soon as we are planning to migrate to newer versions of Eslint. Has there been any discussion to improve this process as it is quite tedious for us and you to update Eslint plugins used by codeclimate.

fede-moya commented 3 years ago

If you would like to take the lead and open some prs for updating the plugin in other branches that good be cool, and I would try to review quickly, but I guess that for the time that you update your system new versions of the plugin might be already released.

Regarding your question about the process, there are some ideas but we need to continue working with them internally. I think for the near future the process will remain as it is, hopefully we can accelerate the manual reviewing process.

fede-moya commented 3 years ago

@SalimBensiali a good friend of mine has already tackle the update on eslint-7 https://github.com/codeclimate/codeclimate-eslint/pull/506 👍🏼