search

codeclimate / codeclimate-eslint

Code Climate Engine for ESLint
MIT License
95 stars 93 forks source link

Add react-perf plugin support #523

Closed MosheZemah closed 3 years ago

MosheZemah commented 3 years ago

Adding support for react-perf plugin

MosheZemah commented 3 years ago

@fede-moya can you approve please?

fede-moya commented 3 years ago

@MosheZemah Hi! 👋🏼

Could you tell me first if you are using an specific channel like eslint-7 or another one ?

MosheZemah commented 3 years ago

@MosheZemah Hi! 👋🏼

Could you tell me first if you are using an specific channel like eslint-7 or another one ?

I've updated our channel to be eslint-7. Thanks

fede-moya commented 3 years ago

@MosheZemah great, then could you open you pr against channel/eslint-7 instead of master please ? I tried to do it myself but your branch it's based on master too so you will need to apply those changes over a branch checked out from channel/eslint-7.

MosheZemah commented 3 years ago

@MosheZemah great, then could you open you pr against channel/eslint-7 instead of master please ? I tried to do it myself but your branch it's based on master too so you will need to apply those changes over a branch checked out from channel/eslint-7.

Hi, created a new PR - https://github.com/codeclimate/codeclimate-eslint/pull/525 Closing this one