QUA-218: Use streams to stringify large jsons

codeclimate / codeclimate-eslint

Code Climate Engine for ESLint

MIT License

95 stars 93 forks source link

QUA-218: Use streams to stringify large jsons #531

Closed noelia-lencina closed 3 years ago

noelia-lencina commented 3 years ago

https://codeclimate.atlassian.net/browse/QUA-218

This intends to process issues as a stream, to avoid passing a large json to JSON.stringify, which may cause memory problems.

efueger commented 3 years ago

@noelia-lencina - ready to merge?

efueger commented 3 years ago

@noelia-lencina to fix tests

fede-moya commented 3 years ago

UPDATE

I followed Noe's advice and I converted the failing integration tests into system tests. The integration tests were failing because they used to depend too much on implementation details.