Update Dockerfile - Githubissues

codeclimate / codeclimate-golint

Code Climate Engine for golint

MIT License

7 stars 6 forks source link

Closed pointlessone closed 7 years ago

pointlessone commented 7 years ago

Updated base image to Alpine 3.4.
codeclimate-golint binary is built inside the container. You don't need Go on your machine any more to build the image.
Updated README to reflect the change. Also gocx is sort of deprecated since go is good at crosscompiling now. Moreover, it's not needed any more because source is compiled to image-native binary.

The image is slightly bigger than the current one (11.52 MiB vs 10.88 MiB).

maxjacobson commented 7 years ago

Nice, glad to see this build step get simpler.

maxjacobson commented 7 years ago

Shoot, the tests didn't actually run and this made the build red. Going to try and make the build green now