search

codeclimate / codeclimate-golint

Code Climate Engine for golint
MIT License
7 stars 6 forks source link

update circle and fix position key #4

Closed ABaldwinHunter closed 9 years ago

ABaldwinHunter commented 9 years ago

Update circle.yml so that forked PRs can pass, following example in [codeclimate-fixme]().

Original goal was to be able to have CI build pass on this PR. The CI build - in a catch 22 of sorts - doesn't pass without the fix in that PR though, so I've added it here as well.

@codeclimate/review @jacobi007

wfleming commented 9 years ago

Should be noted that as-is this is a bit incomplete since the actual compiled bin has not been updated, and right now this project isn't configured to actually build itself on CI, just release. Same problem as I'm attempting to fix with https://github.com/codeclimate-community/codeclimate-govet/pull/6. I think we should use a similar approach here, but in this case we can make the Dockerfile even simpler! I think this would work:

FROM scratch

ADD build/codeclimate-golint /usr/src/app/

RUN adduser -u 9000 -D app
USER app

CMD ["/usr/src/app/codeclimate-govet"]