codeclimate / codeclimate-phpcodesniffer

Code Climate Engine for PHP Code Sniffer
MIT License
28 stars 23 forks source link

Add default file extensions #21

Closed BlakeWilliams closed 8 years ago

BlakeWilliams commented 8 years ago

This adds default file extensions so files are always filtered by at least php, inc, and module.

pbrisbin commented 8 years ago

This LGTM -- I hesitate to ask but... are there tests?

BlakeWilliams commented 8 years ago

Not a single test. :smiley:

I'm not sure how testable the code is in it's current form and I also don't know anything about testing PHP in general.

pbrisbin commented 8 years ago

OK. Manual QA it is I guess

BlakeWilliams commented 8 years ago

Yeah, it's not great but that's how it is for now. Thanks for the reviews!