search

codeclimate / codeclimate-phpcodesniffer

Code Climate Engine for PHP Code Sniffer
MIT License
28 stars 23 forks source link

Introduce remediation points array #23

Closed BlakeWilliams closed 8 years ago

BlakeWilliams commented 8 years ago

This adds the initial version of remediation points based on rule. Since most of the rules are minor they mostly have small values.

I don't believe this is a complete list of rules, but only the ones I ran into in my test projects.

BlakeWilliams commented 8 years ago

The only downside is that I have a file with 106 issues that's still an A, largely because all of these are super minor fixes like adding or removing spaces between operators.

Any thoughts on how much we should increase the points if at all?

BlakeWilliams commented 8 years ago

Maybe bumping everything that's low up by 30k might make a difference?

BlakeWilliams commented 8 years ago

Everything was increased by 40k and it feels better now. The 106 issue class was a C since it was all minor issues.

gdiggs commented 8 years ago

Awesome. LGTM