Exit with code 1 if an exception is raised while analyzing

codeclimate / codeclimate-phpcodesniffer

Code Climate Engine for PHP Code Sniffer

MIT License

28 stars 23 forks source link

Exit with code 1 if an exception is raised while analyzing #38

Closed gdiggs closed 8 years ago

gdiggs commented 8 years ago

forkdaemon doesn't bubble up child errors, as they are separate processes, but we can catch them, log them, and then return false instead of returning a file containing the PHPCS results.

Info on forkdaemon behavior: https://github.com/barracudanetworks/forkdaemon-php/issues/26

@codeclimate/review

pbrisbin commented 8 years ago

LGTM