search

codeclimate / codeclimate-phpcodesniffer

Code Climate Engine for PHP Code Sniffer
MIT License
28 stars 23 forks source link

Autofix using phpcbf (?) #41

Open soderlind opened 8 years ago

soderlind commented 8 years ago

Since phpcbf is included, how about adding the option autofix to the config and have phpcbf fix many of the coding standard errors ?

engines:
    phpcodesniffer:
       enabled: true
       config:
          standard: "WordPress-Core"
       autofix: true
josephdpurcell commented 7 years ago

I believe the intention of Code Climate is to focus on analysis and reporting. Modifications to the code being analyzed (to me) seems out of range, but I'm only a spectator in that regard.

That said, I think in order for this to work I could see two options:

  1. Code Climate be given write access to the repository being analyzed and an integration written to create a pull request (or just a branch) that includes the changes.
  2. Code Climate expand the reporting API and instead of just reporting back a status it also includes a link to a diff/patch that the API consumer could download and apply the patch themselves. This would be a safer option than the first.

In any case, my recommendation would be to only use PHPCBF on a local machine and a manual review of the changes be done before committing, as (in my experience) it does not always do the correct refactoring. Consequently, I don't think this is something I would recommend Code Climate supporting at present.