search

codeclimate / codeclimate-phpcodesniffer

Code Climate Engine for PHP Code Sniffer
MIT License
28 stars 23 forks source link

Explicitly check ignore_warnings is truthy #70

Closed josephdpurcell closed 6 years ago

josephdpurcell commented 6 years ago

Problem

Setting ignore_warnings: false in the .codeclimate.yml does not NOT ignore warnings, i.e. the flag is still set as true.

Proposed Resolution

Correctly handle this setting such that "ignore_warnings: false" means no -n flag is set.

Impact

The potential impact of this change is anyone out there who had "ignore_warnings: false", will now have that settings take affect, which will impact their scoring.