Update PHPCS to 3.5 and update all standards

codeclimate / codeclimate-phpcodesniffer

Code Climate Engine for PHP Code Sniffer

MIT License

28 stars 23 forks source link

Update PHPCS to 3.5 and update all standards #76

Closed Laizerox closed 3 years ago

Laizerox commented 4 years ago

Migrated PHPCS from 2.9 to 3.0+.

PHPCS changed some runner / CLI code and its now migrated. Basic standards PSR1, PSR2, PSR12 are tested and they work. Also quick tests on Symfony and Magento2 were performed.

This PR also updates all standards to highest version available / compatible with latest PHPCS and introduces new Magento2 standard as it was split from old repo.

This PR is related to #75 report.

abenevaut commented 4 years ago

PSR12 is coming! NICE!!!!

doMynation commented 4 years ago

Hi,

The current version used by CodeClimate is severely out of date, and yields a bunch of false positives due to it not being able to parse the latest additions to the PHP language (e.g. flexible heredoc). These false positives are blocking our CI/CD pipeline and basically render CodeClimate unusable for us at the moment.

With that being said, is there any plan to merge and deploy this PR?

Thank you very much.

abenevaut commented 4 years ago

@doMynation, I changed for github actions for codestyle and i'm now using https://codecov.io/ for coverage.

filipesperandio commented 3 years ago

@Laizerox thanks for this. Sorry it took us so long to act. Just merged into beta, we are releasing a channel: beta next, so it will require to tune .codeclimate.yml to use that instead.