search

codeclimate / codeclimate-phpcodesniffer

Code Climate Engine for PHP Code Sniffer
MIT License
28 stars 23 forks source link

QUA-514: update packages and fix sniff-related user errors #90

Closed dantevvp closed 2 years ago

dantevvp commented 2 years ago

This PR updates some of the composer requirements while fixing errors reported by users after the latest image update.

Description

Added php7-xmlreader extension

Fixes error: Class 'XMLReader' not found in /usr/src/app/vendor/wp-coding-standards/wpcs/WordPress/Sniffs/WP/I18nSniff.php

Added /usr/src/app/vendor/slevomat/coding-standard to phpcs's config installed_paths

Fixes error: Referenced sniff "SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" does not exist

Updated pheromone/phpcs-security-audit to version 2.0.1

Fixes error: Exception: Interface 'PHP_CodeSniffer_Sniffs' not found

Added command to copy MEQP folder inside MEQP1 folder in magento/marketplace-eqp package

Fixes error: Trait 'MEQP\Utils\Helper' not found

Issue reference

https://codeclimate.atlassian.net/browse/QUA-514

fede-moya commented 2 years ago

@dantevvp sorry I missed this one, will review tomorrow

fede-moya commented 2 years ago

@dantevvp Closing this one in favor of https://github.com/codeclimate/codeclimate-phpcodesniffer/pull/92, which has already been merged.

dafeder commented 2 years ago

Hey @fede-moya we just started seeing the "SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" error on our beta builds... possible there was something in here that was still needed?