Run one file at a time - Githubissues

codeclimate / codeclimate-phpmd

Code Climate PHPMD Engine

MIT License

10 stars 12 forks source link

Run one file at a time #10

Closed gdiggs closed 8 years ago

gdiggs commented 8 years ago

In my testing, this implode call was taking a really long time to run, and phpmd itself seemed faster when only given one file at a time.

@codeclimate/review

wfleming commented 8 years ago

LGTM. I wonder how this was interacting with the fork-daemon stuff in engine.php that is supposed to provide concurrency.

gdiggs commented 8 years ago

@wfleming As i watched the output (with lots of extra logging), each worker would hang at the implode call for a bit.

wfleming commented 8 years ago

@GordonDiggs Oh, I totally believe you. I'm just unclear on how the fork-daemon is working or what it's doing. I thought the fork-daemon basically dispatched individual files to workers, but this makes it look more like it does some kind of batching? Maybe that's what this line controls.

gdiggs commented 8 years ago

@wfleming I think that is correct