search

codeclimate / codeclimate-phpmd

Code Climate PHPMD Engine
MIT License
10 stars 12 forks source link

Remove unnecessary else #19

Closed landrok closed 8 years ago

landrok commented 8 years ago

https://codeclimate.com/github/codeclimate/codeclimate-phpmd/Category.php

"The method pointsFor uses an else expression. Else is never necessary and you can simplify the code to work without else."

In this case, advise seems to be good.

dblandin commented 8 years ago

LGTM!

dblandin commented 8 years ago

Thanks for the PR @landrok!