search

codeclimate / codeclimate-phpmd

Code Climate PHPMD Engine
MIT License
10 stars 12 forks source link

Equality not assignment #22

Closed gdiggs closed 8 years ago

pbrisbin commented 8 years ago

If only there were tools to catch this...

wfleming commented 8 years ago

The classic error, only slightly less well known than "never get involved in a land war in Asia".

wfleming commented 8 years ago

This LGTM. I'm horrified neither PHP Code Sniffer nor PHPMD caught it. Is there another rule set that would have?

gdiggs commented 8 years ago

Closing this in favor of something like https://github.com/codeclimate/codeclimate-phpcodesniffer/pull/40