search

codeclimate / codeclimate-phpmd

Code Climate PHPMD Engine
MIT License
10 stars 12 forks source link

Avoid printing a php notice for each issue #36

Closed maxjacobson closed 7 years ago

maxjacobson commented 7 years ago

The interpreter wants us to do this end shenanigan. Getting this method under test actually required us to avoid the notice, which is kind of cool.

(rebase, update target branch, and merge after #35)

Should help with #33.

dblandin commented 7 years ago

Side note: Should we be tracking test coverage for this repo with our php test reporter?

maxjacobson commented 7 years ago

Side note: Should we be tracking test coverage for this repo with our php test reporter?

I'm 👍 on that. Increasing the coverage would help catch this kind of thing, and this codebase is small enough that it wouldn't be too hard to cover all/most of the public functions. For what it's worth, this change isn't an urgent bug fix, it's just to help remove some noise while debugging another issue.