search

codeclimate / codeclimate-rubocop

Code Climate Engine for Rubocop
MIT License
60 stars 44 forks source link

Update rubocop to 1.60.2 #363

Closed BrianHawley closed 4 months ago

BrianHawley commented 7 months ago
BrianHawley commented 7 months ago

@fede-moya or @filipesperandio could you review and merge?

BrianHawley commented 6 months ago

@RubyBrewsday you merged the last update. Could you merge this one?

rebeccafae commented 6 months ago

Can someone please merge this?

And thank you @BrianHawley for getting these new channels made for the latest versions. It is much appreciated!

BrianHawley commented 6 months ago

Unfortunately, @rebeccafae, I can't get them to make new channels for the new versions. That's why I got them to make channel/beta, so I can at least make PRs to get an evergreen branch updated.

I'm hoping to eventually get rid of the channel branch system, but I haven't yet allocated the time to do the work.

rebeccafae commented 6 months ago

@BrianHawley do you have a way of using the branch while is it still in the PR? I'd love to be able to start using this.

BrianHawley commented 6 months ago

@rebeccafae I'm not aware of how to use stuff in the codeclimate service or CLI while it's in an unmerged PR.

What I tend to do is set channel: beta for rubocop in my .codeclimate.yml file, just so I can keep as up to date as possible with the service - it is at the last PR, afaik. But to really use rubocop, I use it locally in my own codebase, directly.

I don't use the other channels, just beta. The current method they use to make channels is to create a branch for each channel here, and I can't practically get such branches created. The solution to this would be to change how they do channels for rubocop, both here and in the main codeclimate repository. I have some ideas about how to do this, but haven't had the time, yet.

rebeccafae commented 5 months ago

Since we're past the holidays, any chance someone could review and merge this? @RubyBrewsday @fede-moya @filipesperandio

filipesperandio commented 5 months ago

Hey, @rebeccafae ! I am away from the project a while now, but will ask the guys to take a look when they can. @fede-moya would you have some availability?

rebeccafae commented 5 months ago

@fede-moya any chance you are able to merge this?

kayodeadeniyi commented 4 months ago

We are waiting on this version of the channel to be merged in. Any chance we could get this soon?

rebeccafae commented 4 months ago

Since this is only going to the beta branch and not an official channel, is there a reason this can't just be merged as-is without a thorough review? @fede-moya @filipesperandio

fede-moya commented 4 months ago

Yes, I'm sorry.