Revert "Renamed wrapper (#51)"

toddmazierski commented 6 years ago

This reverts commit f43e380d6aa38c81da50ffe27c38796b3643cdab.

There are 2 test failures in the master branch:

integration.JavaSourceVersion >
  specify_java_source_version_through_config FAILED

integration.SanityCheckTest >
  executeJavaLibFixture FAILED

Reverting this commit puts the build back in a good state, and there's a chance it also addresses codeclimate/codeclimate#827.

Before:

codeclimate analyze -e sonar-java
Starting analysis
Running sonar-java: Done!
error: (CC::CLI::Analyze::EngineFailure) engine sonar-java failed
with status 99 and stderr
engine produced invalid output: {:message=>"Invalid JSON",
:output=>"INFO: Java 1.8.0_111-internal Oracle Corporation (64-bit)
…

After:

codeclimate analyze -e sonar-java
Starting analysis
Running sonar-java: Done!
…
Analysis complete! Found 76 issues.

filipesperandio commented 6 years ago

@toddmazierski I don't see the failing tests in CI. Could you point me to them? The repo rename was something SonarSource asked us to do, so reverting it back does not sound like a good idea. Although, GH keep the old name and make the redirects...

toddmazierski commented 6 years ago

@filipesperandio, it's weird— the last master of this project passed on CircleCI:

https://circleci.com/gh/codeclimate/codeclimate-sonar-java/156

But if you check out the project locally and run make test, you'll get the failures. I think we'd probably get the failures in CircleCI if we were to rebuild, too.

filipesperandio commented 6 years ago

@toddmazierski I see... probably due to the renaming thing, but still odd.

toddmazierski commented 6 years ago

Closing! I've done some more debugging with @filipesperandio and we believe we found the problem.

codeclimate / codeclimate-sonar-java

Revert "Renamed wrapper (#51)" #52