search

codeclimate / ruby-test-reporter

DEPRECATED Uploads Ruby test coverage data to Code Climate
https://codeclimate.com
Other
92 stars 92 forks source link

Add support for env variable for `committed_at` in Codeship payload #168

Closed antoniobg closed 7 years ago

antoniobg commented 7 years ago

We run into this issue https://github.com/codeclimate/ruby-test-reporter/issues/156 where we couldn't get the test coverage to work unless we included the .git folder in the docker image. We've forked the repository and now we pass an environment variable with the date of the last commit, so we don't need to include that .git folder. Not sure if it's something you want to include in your repository, but just in case I'm creating the PR.

antoniobg commented 7 years ago

Thank you very much @maxjacobson, I think I've addressed all the issues you mentioned.

antoniobg commented 7 years ago

@maxjacobson it failed because it was taken the branch name of this PR pull\168, and the spec was expecting the branch name master.

antoniobg commented 7 years ago

No worries and thank you for accepting the PR!