Get commit hash from CI if failed to get it from Git

codeclimate / ruby-test-reporter

DEPRECATED Uploads Ruby test coverage data to Code Climate

https://codeclimate.com

Other

92 stars 92 forks source link

Get commit hash from CI if failed to get it from Git #177

Closed sullerandras closed 7 years ago

sullerandras commented 7 years ago

This is fixing the issue that code coverage is not reported correctly when .git folder is not present. Related issues: command not found: git - https://github.com/codeclimate/ruby-test-reporter/issues/171 Feature - run on Codeship out of the box - https://github.com/codeclimate/ruby-test-reporter/issues/156 CodeClimate::TestReporter::Git doesn't use branch_from_git_or_ci - https://github.com/codeclimate/ruby-test-reporter/issues/115

maxjacobson commented 7 years ago

@sullerandras Hi, and thanks so much for this PR! I really appreciate your help.

maxjacobson commented 7 years ago

This is released as v1.0.7

pabloroz commented 7 years ago

I think this still failing if git is not installed in the container, right?

maxjacobson commented 7 years ago

@pabloroz My expectation is that it shouldn't fail when git is not installed. It may print out a warning to that effect, but the reporter should fall back to the values in the CI environment, if available. Please let us know if you're seeing something different.