search

codeclimate / test-reporter

Code Climate Test Reporter
MIT License
156 stars 76 forks source link

Support clover `path` attribute on file nodes in XML report #349

Closed dblandin closed 6 years ago

dblandin commented 6 years ago

The XML report generated by more recent versions of clover include the full path to the file within a path attribute. The name attribute in these reports contains just the filename without any directory structure.

To support reading the source file, we'll need to reference this new attribute.

ale7714 commented 6 years ago

@dblandin this LGTM overall, do you know if the attribute path is not present on older versions of the XML report?

dblandin commented 6 years ago

I'm not sure which is why I added the fallback.

dblandin commented 6 years ago

@ale7714 For what it's worth, the fixture example included in this repo does not include the path attribute: https://github.com/codeclimate/test-reporter/blob/master/formatters/clover/example.xml#L5