codeclimate / test-reporter

Code Climate Test Reporter
MIT License
154 stars 76 forks source link

QUA-1062: Release test reporter for windows #511

Closed camillof closed 1 year ago

camillof commented 1 year ago

I'll update the README and public docs once we've the links for the new versions

camillof commented 1 year ago

hey millo, we won't be able to build windows version locally right ? (if using a non-windows machine)

Yep we do! Actually, the test binary I shared on previous days was generated on my non-windows machine.

That's because we're using Golang to build them, so theoretically, you should be able to build for any architecture, from any other architecture.

camillof commented 1 year ago

These changes look good to me. I have a question though, I noticed that out of all of the different formatters we have you only needed to modify the gocov formatter. Does that mean that gocov is the only formatter that needed changes to be use on a windows platform or it means that is the only formatter we will suport for windows to start ?

The gocov formatter was the only one that failed the tests after implementing the windows test. I think it's because it's the only one that manually handle paths, and harcoding them wasn't a good idea (/ vs \ on windows).

Also, we manually tested the test reporter with other formatters (I personally tested dot net, and the ruby one was tested by Dante and Mike), so they should also work

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 491e210c and detected 0 issues on this pull request.

View more on Code Climate.