search

codecombat / codecombat

Game for learning how to code.
http://codecombat.com
MIT License
7.98k stars 4.13k forks source link

Actions sometimes activated again all at once improperly #1757

Closed nwinter closed 1 year ago

nwinter commented 10 years ago

This has the result that all the dead units get up in order to die again. I would have said it's probably something to do with world streaming chunks improperly setting actionActivated to true, but now just looking at when it happened, it doesn't reproduce when scrubbing past the same point on the same run again, so maybe it is something to do with real-time playback instead?

gsaines commented 9 years ago

https://app.asana.com/0/15388757953815/20686183437360

nwinter commented 8 years ago

This happens when spritesheets are rerendered after resizing everything to a smaller spritesheet: https://github.com/codecombat/codecombat/blob/master/app/lib/surface/LayerAdapter.coffee#L294 – maybe we need to maintain old animation frames when rerendering? At least rerender less often.

nwinter commented 8 years ago

@sderickson how hard to maintain old animation frames when rerendering?

sderickson commented 8 years ago

Maybe a few hours to figure out?

nwinter commented 1 year ago

Fixed in c56ec2c, at least for SegmentedSprites!