Use simple loops in all levels' Lua sample code

[nwinter]

We used to have to have code like this for Lua, since we had no simple loop keyword, and so we had to help the player avoid infinite loops:

while true do
    -- whatever the sample code is

    self:say("Remove this line once your loop is finite.")
end

Now we can rewrite that to:

loop
    -- whatever the sample code is
end

(The simple loop will automatically yield for one frame if no action is taken, so you can't get an infinite loop by not doing move, attack, say, or some other blocking action.)

We need to update the Lua sample code in pretty much all levels to use the new loop keyword instead, and to get rid of the placeholder say lines. The first few levels have no loops, and some of the last ones in the desert actually are teaching while true do loops, and some levels have just comments for sample code, but everything else will need updating.

To update the Lua sample code:

1. Open the level editor
2. Double-click the Hero Placeholder
3. Click programming.Programmable on the left
4. Open programmableMethods -> plan -> languages -> lua
5. Update the Lua sample code.
6. Submit a patch
7. Post (or update) your comment here saying which ones you've done.

I've definitely missed some that actually just have comments for sample code, but this is the list I know about so far:

• [x] Haunted Kithmaze
• [x] Riddling Kithmaze
• [x] Descending Further
• [x] The Second Kithmaze
• [x] Dread Door
• [x] Cupboards of Kithgard
• [x] Hack and Dash
• [x] Breakout
• [x] Dueling Grounds
• [x] Kithgard Gates
• [x] Kithgard Brawl
• [x] Patrol Buster
• [x] Endangered Burl
• [x] Village Guard
• [x] Thornbush Farm
• [x] Back to Back
• [x] Ogre Encampment
• [x] Woodland Cleaver
• [x] Shield Rush
• [x] Peasant Protection
• [x] The Agrippa Defense
• [x] Munchkin Harvest
• [x] Arcane Ally
• [x] Munchkin Swarm
• [x] Backwoods Brawl
• [x] Swift Dagger
• [x] Touch of Death
• [x] Shrapnel
• [x] Bonemender
• [x] Coinucopia
• [x] Hold the Forest Pass
• [x] Copper Meadows
• [x] Drop the Flag
• [x] Backwoods Treasure
• [x] Deadly Pursuit
• [x] Rich Forager
• [x] Hold for Reinforcements
• [x] Storming the Farmhouse
• [x] Unfair Support
• [x] Tactical Timing
• [x] Doom Glade
• [x] Defend the Garrison
• [x] Multiplayer Treasure Grove
• [x] Cavern Survival
• [x] The Dunes
• [x] The Mighty Sand Yak
• [x] Oasis
• [x] Sarven Road
• [x] Sarven Gaps
• [x] Thunderhooves
• [x] Wild Horses
• [x] The Great Yak Stampede
• [x] Medical Attention
• [x] Minesweeper
• [x] Sarven Sentry
• [x] Keeping Time
• [x] Hoarding Gold
• [x] Decoy Drill
• [x] Yakstraction
• [x] Sarven Brawl
• [x] Desert Combat
• [x] Sarven Rescue
• [x] Sacred Statue
• [x] Dust
• [x] Mirage Maker
• [x] Sarven Savior
• [x] Odd Sandstorm
• [x] Lurkers
• [x] Preferential Treatment
• [x] Sarven Shepherd
• [x] Shine Getter
• [x] Sarven Treasure
• [x] Mad Maxer
• [x] Mad Maxer Strikes Back
• [x] Mad Maxer Sells Out
• [x] Mad Maxer Gets Greedy
• [x] Mad Maxer: Redemption
• [x] Sarven Siege
• [x] Clash of Clones
• [x] Harrowland

[h3yduck]

Submitted patch for: Haunted Kithmaze Riddling Kithmaze Hack and Dash Patrol Buster Endangered Burl

The Second Kithmaze - it has comment only Breakout - no default source code Dueling Grounds - it has comment only Kithgard Gates - no loop in default source code Kithgard Brawl - it has comment only

[Khoffee]

Submitted patch for:

• Touch of Death
• Shrapnel
• Bonemender
• Coinucopia
• Hold the Forest Pass

[wincheng]

Submitted patch for:

• Back to Back
• Ogre Encampment
• Woodland Cleaver
• Peasant Protection

[tvdang]

submitted patch for -back to back -Rich forager -drop the flag -Unfair support -Thunderhooves -Medical attention -sarven sentry -decoy drill -Shine getter

[divyanshu013]

Submitted patch for:

1. Village Guard
2. The Agrippa Defense

Shield rush has comments only

[laituan245]

Submitted patch for:

• Deadly Pursuit
• Hold for Reinforcements
• Oasis
• Sarven Gaps
• Wild Horses

Mirage Maker - it has comment only Backwoods Treasure - it has comment only Minesweeper - it has comment only Dust - no loop in default source code

[nwinter]

Awesome, great work so far y'all! A bunch of the remaining levels might be because they're paid levels, and I guess maybe the level editor doesn't let you open those. But there are still some free ones left that either need doing or need a heads up that they don't need simple loops in them.

[laituan245]

Submitted patch for:

• Thornbush Farm
• Munchkin Swarm
• Mad Maxer Strikes Back
• Mad Maxer Sells Out
• Mad Maxer Gets Greedy
• Mad Maxer: Redemption

Clash of Clones - it has comment only Backwoods Brawl - it has comment only The Great Yak Stampede - it has comment only

[laituan245]

Tactical Timing - it has comment only Doom Glade - no default Lua source code Defend the Garrison - it has comment only Yakstraction - it has comment only Sarven Brawl - it has comment only Sarven Rescue - it has comment only Preferential Treatment - no loop in default source code

[divyanshu013]

The Dunes -> Patch submitted Copper Meadows -> Patch submitted Swift Dagger -> Patch submitted

Harrowland -> Comments only Preferential Treatment -> Comments only Mirage Maker -> Comments only Sacred Statue -> Comments only Yakstraction -> Comments only Hoarding Gold -> No Lua source Keeping Time -> Comments only Cavern Survival -> No Lua source Multiplayer Treasure Grove -> Comments only Defend the Garrison -> Comments only Doom Glade -> No Lua source Tactical Timing -> Comments only Arcane Ally -> Comments only Munchkin Harvest -> Comments only Shield Rush -> Comments only

Lurker -> Uses a while loop Odd Sandstorm -> Uses a while loop Desert Combat -> Uses a while loop

Sarven Seige -> Unable to access

[divyanshu013]

That should cover all @nwinter

[nwinter]

Wonderful! Good hustle, team. Hopefully we can soon apply the same simple loop logic for CoffeeScript and do the same thing for those levels.