search

codecombat / treema

jQuery plugin that generates HTML interfaces to edit JSON data defined by json-schema.
http://codecombat.github.io/treema/
MIT License
152 stars 36 forks source link

Bring Treema to Bower #15

Closed dkundel closed 10 years ago

dkundel commented 10 years ago

I added necessary files and changed the file describing the usage of it. However in order to work perfectly we should figure out the exact dependency of jQuery and jQuery UI. Bower will at the moment install all dependencies properly however the jQuery version that is currently specified as dependency does not offer a bower.json that specifies the main files. This means that if someone uses something such as grunt-bower-install to automatically include scripts into their project, jQuery needs to be included manually.

If we can figure out that it supports newer versions of jQuery (which should be the case) we can update the bower.json and fix this issue. At the moment you can test the bower installation using:

    bower install git@github.com:dkundel/treema.git

If you want to see the problem I'm talking about run afterwards bower list --paths it will show the correct paths for everything but jQuery.

sderickson commented 10 years ago

Switching to the next version of jQuery sounds good. It shouldn't be hard to check; the tests just need to be run for that version.