search

codecombat / treema

jQuery plugin that generates HTML interfaces to edit JSON data defined by json-schema.
http://codecombat.github.io/treema/
MIT License
152 stars 36 forks source link

Finally managed to find the bug that made regex matches fail #27

Closed rubenvereecken closed 10 years ago

rubenvereecken commented 10 years ago

This took me longer to find than I'd care to admit. Regex is matched against the wrong variable (against itself actually), resulting in most regexes to fail. At first I skipped the regex match but that would result in too much schemas to be matched.

This one's for Mongo queries inside CodeCombat achievements :)

nwinter commented 10 years ago

Nice catch. Randomly noticed that Scott seems to have been on a Python binge when writing the child schema key code, since there are some variables named with snake case throughout the file, but only when dealing with child schema keys. :smiling_imp:

rubenvereecken commented 10 years ago

Wrote some tests for Scott :)