search

codecov / browser-extension

Codecov Browser Extension
http://codecov.io
Apache License 2.0
214 stars 60 forks source link

Green color miss #11

Closed hhfrancois closed 8 years ago

hhfrancois commented 8 years ago

again under Firefox, toggle button is on, but color not active. switch button two times (off, on) and that works ...

capture d ecran 3 capture d ecran 4

stevepeak commented 8 years ago

There are three "modes" for overlaying coverage. Clicking the bottom (or tapping c on the keyboard) will toggle between then: 1 -> 2 -> 3 -> 1 etc.

  1. (first by default) Show only "hit & missed"
  2. Disable overlay
  3. Overlay everything.

You can change this behavior in the settings of extension. Find Codecov and change Initial coverage view to your specific choice.

If you have a suggestion to change this behavior please let me know :+1: Thank you!

kt3k commented 8 years ago

Hi,

I did the same misunderstanding as @hhfrancois. (Now it's solved.)

I think the UI is a little bit misleading because it seems to suggest there are only 2 modes. (no visual difference of buttons for 1 and 3)

stevepeak commented 8 years ago

@kt3k I understand your comment above. I may consider changing this to be 2 modes: On/Off (as the button suggests)

I'll be updating the extension soon and will consider this. Thank you!

stevepeak commented 8 years ago

Upcoming version will have only two options: On/Off. Thanks!

kt3k commented 8 years ago

Thanks for updating! I like this simpler version much better! :+1: