dcramer
commented
8 years ago IMO show both, possibly within the same button?
Coverage 96.77% (100% Diff)
And if you can, extend the TOC (this is the area we really care about).
Basically what we want to do is look at a PR and see "cool, all lines of code are run by robots". We're going to try out the PR comments but in my experience those are way too noisy. Ideally GitHub could provide better hooks for this so you could just manage some state on things, but I can't imagine that happening.
This is primarily an ask due to all of us previously using Phabricator at companies we worked at, which has the best code review flow process of any system I've ever seen.
I'll use this as a reference:
https://secure.phabricator.com/D14295
While they don't seem to have coverage enabled for their own code, the first thing you'd usually see is something in the file's table of contents:
https://www.dropbox.com/s/joux2a0haqtw0l5/Screenshot%202015-10-18%2022.16.23.png?dl=0
Two columns would existing showing diff coverage and total coverage. You primarily focus on "was this change covered by tests" or "how much of it was".
Additionally it does inline coverage in a really nice way. Effectively it keeps the diff view (even though it does side by side), and it attaches indicators in the sidebar instead of overlaying the entire line. You can see an example of that in a screenshot here:
stevepeak
Concept 2
Have more concepts? Feel free to comment below!