codecov / browser-extension

Codecov Browser Extension
http://codecov.io
Apache License 2.0
214 stars 60 forks source link

Coverage did not change is reported even though it changed #33

Open wilzbach opened 7 years ago

wilzbach commented 7 years ago

image

from this PR https://github.com/dlang/phobos/pull/4647

It seems to be an UI error, maybe the overall coverage is only reported from the first file of the diff or there is some rounding involved?

wilzbach commented 7 years ago

I also get other weird UI errors - like this one (the coverage did change)

image

https://github.com/dlang/phobos/pull/4680/files

stevepeak commented 7 years ago

coverage did change

This may be the case when overall coverage is equal and the diff does not affect the overall coverage. Ex.

# overall coverage before 50%

- this line was hit
+ this line was hit
- miss
- miss
- miss
+ miss
+ miss
+ miss

# diff coverage is 25%
# coverage after 50%. Diff 50%
jammyto10 commented 6 years ago

+