search

codecov / browser-extension

Codecov Browser Extension
http://codecov.io
Apache License 2.0
214 stars 60 forks source link

Uncaught ReferenceError: $ is not defined #55

Open lbergelson opened 6 years ago

lbergelson commented 6 years ago

I noticed that the code coverage is only showing up sporadicly on pull requests. I'm not sure why I see it sometimes and why sometimes I don't. I looked in the console and it seems like there's an error in one of the codecov listening scripts though. Googling around makes it sound like it might be problem with jquery not being available.

screen shot 2018-03-20 at 12 37 11 pm screen shot 2018-03-20 at 12 37 19 pm
dannyroa commented 6 years ago

I'm seeing this as well.

ianepperson commented 6 years ago

I'm seeing this too. Likely needs to add an additional check for typeof $ === "undefined"

aidanlister commented 6 years ago

Yeah me too :(

jallen1788 commented 6 years ago

Me too

amercier commented 6 years ago

...or simply remove usage of jQuery entirely, as addEventListener and postMessage are widely supported now.

@stevepeak Would you accept a PR on this? I proposed the change in #58

dannyroa commented 6 years ago

I hope this will be fixed. We're paying for your service and we don't even get a response from you.