search

codecov / browser-extension

Codecov Browser Extension
http://codecov.io
Apache License 2.0
214 stars 60 forks source link

Fix for fetching tree files that have slashes in URL #7

Closed jpulec closed 9 years ago

jpulec commented 9 years ago

Fetch the full branch name from the data-ref of the select on the page, since parsing based on slashes is unreliable.

stevepeak commented 9 years ago

@jpulec thanks for the PR. Unfortunatly this method does not work for tree views at a specific sha. This example returns an empty string

Can you provide a link that uses a backslash so I can try some other methods? Thanks!

codecov-io commented 9 years ago

Current coverage is 75.63%

Merging pull/7 into master will change coverage by +3.66% by 78773c5

Coverage Diff

@@            master   pull/7   diff @@
=======================================
  Files            4        3     -1
  Stmts          239      160    -79
  Branches         0        0       
  Methods          0        0       
=======================================
- Hit            172      121    -51
  Partial          0        0       
+ Missed          67       39    -28

Powered by Codecov

jpulec commented 9 years ago

That should fix it. Unfortunately, I don't have any public repos that have a backslash in the branch name, just private ones.

stevepeak commented 9 years ago

Thanks! Let me know if parsing branch names in other spots causes issues.