codecov / codecov-action

GitHub Action that uploads coverage to Codecov :open_umbrella:
https://www.codecov.io
MIT License
1.42k stars 198 forks source link

Not valid tokenless upload #1487

Open greg0ire opened 2 weeks ago

greg0ire commented 2 weeks ago

I believe this has been happening for a few weeks now, but many of our PRs using tokenless upload (they are PRs from open source forks) fail with Report creating failed: {"detail":"Not valid tokenless upload"}

Here is an example: https://github.com/doctrine/dbal/actions/runs/9554014292/job/26334506168

thomasrockhu-codecov commented 2 weeks ago

@joseph-sentry do you mind taking a look here?

joseph-sentry commented 2 weeks ago

@thomasrockhu-codecov since we made the API changes for the new tokenless, unless a user is using the updated CLI (which hasn't been released yet) and the updated action, tokenless won't work

ybiquitous commented 2 weeks ago

Hi, I encounter a similar issue.

The new CLI version was released recently (https://github.com/codecov/codecov-cli/releases/tag/v0.7.0), but my problem still occurs.

Here's the failed log of a fork PR in the stylelint repo (https://github.com/stylelint/stylelint/pull/7777):

==> Fork detected, tokenless uploading used

at https://github.com/stylelint/stylelint/actions/runs/9605083708/job/26494382161?pr=7777#step:7:16

==> Running version v0.7.0

at https://github.com/stylelint/stylelint/actions/runs/9605083708/job/26494382161?pr=7777#step:7:33

Error: Codecov token not found. Please provide Codecov token with -t flag.

at https://github.com/stylelint/stylelint/actions/runs/9605083708/job/26494382161?pr=7777#step:7:44

It would be great if you could help. Thanks. 🙏🏼

ybiquitous commented 2 weeks ago

In addition, here's a successful log with the CLI v0.6.0:

==> Running version v0.6.0

at https://github.com/stylelint/stylelint/actions/runs/9601142978/job/26479023288?pr=7776#step:7:33

qweeah commented 2 weeks ago

Looks like this is introduced by the Codecov CLI v0.7.0. Since the GPG SUM of v0.6.0 does not exist any more, is it possible to reset the Codecov CLI back to 0.6.0 without checking the GPG sum? Downgrade CLI to v0.6.0 works.

bdrung commented 2 weeks ago

We have the same issue with Apport. Example failed upload: https://github.com/canonical/apport/actions/runs/9506858733/job/26508430770?pr=355

joseph-sentry commented 2 weeks ago

Hi all, indeed tokenless uploads were broken for v0.7.0 of the CLI, we just released v0.7.1 which should fix that bug. If you've already versioned to v0.6.0, that should work fine as well.

ybiquitous commented 2 weeks ago

@joseph-sentry Thanks for the quick patch! I'll try it soon. 👍🏼

By the way, the release notes and the changelog link seem incorrect to me in https://github.com/codecov/codecov-cli/releases/tag/v0.7.1 because of too many items. 👀

ybiquitous commented 2 weeks ago

@joseph-sentry Unfortunately, the problem doesn't seem to be resolved. 😢

Error: Codecov token not found. Please provide Codecov token with -t flag.

https://github.com/stylelint/stylelint/actions/runs/9617068584/job/26528019385?pr=7783#step:7:44

PR: https://github.com/stylelint/stylelint/pull/7783


EDIT: I confirmed v0.7.1 was used:

==> Running version v0.7.1

https://github.com/stylelint/stylelint/actions/runs/9617068584/job/26528019385?pr=7783#step:7:33

thomasrockhu-codecov commented 1 week ago

@ybiquitous would you mind trying to re-run again? I think this may have just been a caching thing on our side

mrmundt commented 1 week ago

@thomasrockhu-codecov - We tried 0.7.1 and are still getting the issue: https://github.com/Pyomo/pyomo/actions/runs/9682305560/job/26718272498?pr=3303

ybiquitous commented 1 week ago

@thomasrockhu-codecov Thanks for your reply. Uploading is now successful! 🎉

Here's the log: ⬇️

==> Fork detected, tokenless uploading used

https://github.com/stylelint/stylelint/actions/runs/9688239908/job/26734397467?pr=7804#step:7:10

==> Running version v0.7.1

https://github.com/stylelint/stylelint/actions/runs/9688239908/job/26734397467?pr=7804#step:7:33

info - 2024-06-26 23:42:35,916 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/stylelint/stylelint/commit/da38c532a0f23843b24f723f664a8ec187a9538c
info - 2024-06-26 23:42:36,095 -- Process Upload complete

https://github.com/stylelint/stylelint/actions/runs/9688239908/job/26734397467?pr=7804#step:7:54

thomasrockhu-codecov commented 1 week ago

@greg0ire @qweeah @bdrung @mrmundt we made some changes to the Action and CLI, would you mind uploading again and see if you are running into the issue?

greg0ire commented 5 days ago

@thomasrockhu-codecov I've tried re-running the build in my original message, and sadly, the result appears to be the same: https://github.com/doctrine/dbal/actions/runs/9554014292/job/26861037163

The output indicates that 0.7.2 was in use.

qweeah commented 5 days ago

@thomasrockhu-codecov Switched to v0.7.2 and the upload is successful, thank you all for the quick response.

mrmundt commented 4 days ago

@thomasrockhu-codecov - Also still not working over here: https://github.com/Pyomo/pyomo/actions/runs/9751098274/job/26913971560?pr=3303