Closed josecelano closed 1 week ago
It's also failing with the latest version: 4.5.0. See https://github.com/josecelano-test/pull_request_target/actions/runs/9907290283/job/28115928698#step:1:29
Download action repository 'codecov/codecov-action@v4' (SHA:e28ff129e5465c2c0dcc6f003fc735cb6ae0c673)
It's also failing with the latest version: 4.5.0. See https://github.com/josecelano-test/pull_request_target/actions/runs/9907290283/job/28115928698#step:1:29
Download action repository 'codecov/codecov-action@v4' (SHA:e28ff129e5465c2c0dcc6f003fc735cb6ae0c673)
Same for me. I'm wondering why in the log the first character of the token isn't masked: "token": "e******************"
For me (https://github.com/gcovr/gcovr/actions/runs/10461552705/job/28970126469) it shows "token": "6******************"
but the token doesn't start with a 6
.
We seem to be having the same issue here: https://github.com/uber/h3-py/pull/389
We see the same issue in https://github.com/Trusted-AI/adversarial-robustness-toolbox. The new action codecov-action@v4 and secret for Dependabot have worked for the Dependabot-PR updating to codecov-action@v4, but it seems not to work for PRs already opened by Dependabot before upgrading to codecov-action@v4. I have not yet observed new Dependabot PRs and if codecov-action@v4 would work there.
@josecelano we made some changes to the backend, do you mind trying v4 again?
Hi @thomasrockhu-codecov, I've tried to re-try the workflow execution but now I have an error in the cargo build command. It seems one of the Rust flags I'm using was removed in the meantime. And the action I use to generate the coverage data looks unmaintained, too :-(
https://github.com/alekitto/grcov
I need to fix all those issues to recheck.
The error:
Run echo ""
echo ""
cargo clean
cargo build
cargo test -- --nocapture
shell: /usr/bin/bash -e {0}
env:
CARGO_TERM_COLOR: always
CARGO_INCREMENTAL: 0
RUSTFLAGS: -Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests
RUSTDOCFLAGS: -Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests
CARGO_HOME: /home/runner/.cargo
CACHE_ON_FAILURE: false
Removed 0 files
error: failed to run `rustc` to learn about target-specific information
Caused by:
process didn't exit successfully: `/home/runner/.rustup/toolchains/nightly-x86_6[4](https://github.com/josecelano-test/pull_request_target/actions/runs/11687789182/job/32546696039?pr=17#step:12:4)-unknown-linux-gnu/bin/rustc - --crate-name ___ --print=file-names -Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 1)
--- stderr
warning: the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
error: unknown unstable option: `profile`
Oh geez, sorry to see that @josecelano. To be honest I'm not a rust developer, so I'm really not sure how to help, but let me know if there is something I can do
Hi @thomasrockhu-codecov I've created a new workflow in my sample project:
In the lastest workflow execution, the report was generated successfully, and it was also uploaded to codecov:
https://github.com/josecelano-test/pull_request_target/actions/runs/11690464665/job/32555468619
However, the repot page on codecov is empty:
I'm trying to generate the report without using a GitHub action. I can see the report locally in HTML format, this is the coverage info I'm uploading:
lcov.info
SF:/home/josecelano/Documents/git/committer/me/github/josecelano-test/pull_request_target/src/main.rs
FN:7,_RNvCsgzubYbVaq0u_19pull_request_target9greetings
FN:18,_RNvNtCsgzubYbVaq0u_19pull_request_target5testss_15it_should_greet
FN:3,_RNvCsgzubYbVaq0u_19pull_request_target4main
FNDA:1,_RNvCsgzubYbVaq0u_19pull_request_target9greetings
FNDA:1,_RNvNtCsgzubYbVaq0u_19pull_request_target5testss_15it_should_greet
FNDA:0,_RNvCsgzubYbVaq0u_19pull_request_target4main
FNF:3
FNH:2
DA:3,0
DA:4,0
DA:5,0
DA:7,1
DA:8,1
DA:9,1
DA:18,1
DA:20,114
DA:21,113
DA:22,113
DA:24,1
DA:25,1
BRF:0
BRH:0
LF:12
LH:9
end_of_record
@josecelano are you running this as a pull_request or push event? I see workflow_run
and pull_request_target
, and I was curious about your use case. I haven't tested those flows out in awhile and want to make sure that I understand
@josecelano are you running this as a pull_request or push event? I see
workflow_run
andpull_request_target
, and I was curious about your use case. I haven't tested those flows out in awhile and want to make sure that I understand
Hi @thomasrockhu-codecov in that case is a push event.
Is there an example of using the codecov client with a valid Lcov file somewhere?
@josecelano ok, I'm actually seeing a permissions error on our side. Can you try 2 things
v5-beta
tag for the codecov-action
?@josecelano ok, I'm actually seeing a permissions error on our side. Can you try 2 things
- switch to
v5-beta
tag for thecodecov-action
?- double-check that the token supplied is for this particular repo from codecov.io?
Hey @thomasrockhu-codecov, the token was wrong. I probably thought that the token was per user, not per project. After changing the token, I was able to see a new error. I have continued working on the example, and it works now. Thank you very much for your support!!! And sorry for my mistake.
The full working example is here: https://github.com/josecelano-test/pull_request_target
And the latest coverage report: https://app.codecov.io/github/josecelano-test/pull_request_target/commit/bb0e9789b1417b857e2d09c2c76e1596b96a98e0
@josecelano no worries, glad that it worked for you! Pesky tokens
I'm using a token, but I'm getting this error:
The workflow: https://github.com/josecelano-test/pull_request_target/blob/develop/.github/workflows/upload_coverage_pr.yaml#L104-L119
I have another workflow using version 3, and it works:
https://github.com/josecelano-test/pull_request_target/blob/develop/.github/workflows/coverage.yaml#L78-L85