search

codecov / codecov-action

GitHub Action that uploads coverage to Codecov :open_umbrella:
https://www.codecov.io
MIT License
1.5k stars 212 forks source link

Autodetect ARM runners support #650

Open Antonito opened 2 years ago

Antonito commented 2 years ago

Hello,

I've been trying to use this action in a self-hosted ARM64 Linux runner but the action pulls a x86_64 ELF instead of an ARM64 one:

ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=f63fec383878964009a2418a624a6ed92c762dad, for GNU/Linux 2.6.32, stripped

Is there any plan to support this?

I guess a work-around would be to manually build https://github.com/codecov/uploader for this architecture, but I'd much rather use the codecov-action to keep a consistent .yaml between self-hosted runners & the Github ones

Edit: Blocked by https://github.com/codecov/uploader/issues/523

cschmatzler commented 1 year ago

This is solved in the new version by providing os: aarch64.

Porges commented 1 year ago

@cschmatzler This is solved in the new version by providing os: aarch64.

Can we have this be auto-detected by the script? I don't need to specify Windows or Linux so it would be nice if this just worked as well.

freef4ll commented 1 year ago

Yes still an issue; according to docs aarch64 is not documented and this is not OS...

/Users/runner/actions-runner/_work/_actions/codecov/codecov-action/v3/dist/codecov -n  -Q github-action-3.1.4 -f info.lcov -C 6ab438a7a065017f970c8e58afbb3b53b1703917
Error: spawn Unknown system error -86
zsh: bad CPU type in executable: /Users/runner/actions-runner/_work/_actions/codecov/codecov-action/v3/dist/codecov
0xAlcibiades commented 1 year ago

This is already supported in the underlying coverage uploader tool now. A fix here would be clutch.